From 747b2dc7c5e595351ec36d283912203c40a1c928 Mon Sep 17 00:00:00 2001 From: Moxie Marlinspike Date: Thu, 3 Dec 2015 16:40:04 -0800 Subject: [PATCH] Jedis sanity checks // FREEBIE --- .../textsecuregcm/storage/PubSubManager.java | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/whispersystems/textsecuregcm/storage/PubSubManager.java b/src/main/java/org/whispersystems/textsecuregcm/storage/PubSubManager.java index f8ba60d6a..f721a1866 100644 --- a/src/main/java/org/whispersystems/textsecuregcm/storage/PubSubManager.java +++ b/src/main/java/org/whispersystems/textsecuregcm/storage/PubSubManager.java @@ -5,6 +5,8 @@ import org.slf4j.LoggerFactory; import org.whispersystems.dispatch.DispatchChannel; import org.whispersystems.dispatch.DispatchManager; +import java.util.Arrays; + import io.dropwizard.lifecycle.Managed; import static org.whispersystems.textsecuregcm.storage.PubSubProtos.PubSubMessage; import redis.clients.jedis.Jedis; @@ -63,7 +65,13 @@ public class PubSubManager implements Managed { private boolean publish(byte[] channel, PubSubMessage message) { try (Jedis jedis = jedisPool.getResource()) { - return jedis.publish(channel, message.toByteArray()) != 0; + long result = jedis.publish(channel, message.toByteArray()); + + if (result < 0) { + logger.warn("**** Jedis publish result < 0"); + } + + return result > 0; } }