From 61b3cecd171b0b5c451e4d50bd4f8dbbed70e9dd Mon Sep 17 00:00:00 2001 From: Ravi Khadiwala Date: Wed, 14 Sep 2022 16:58:25 -0500 Subject: [PATCH] Fix missing increment on recaptcha counter --- .../textsecuregcm/recaptcha/RecaptchaClient.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/recaptcha/RecaptchaClient.java b/service/src/main/java/org/whispersystems/textsecuregcm/recaptcha/RecaptchaClient.java index 495772fc9..dc53b70c2 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/recaptcha/RecaptchaClient.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/recaptcha/RecaptchaClient.java @@ -132,7 +132,8 @@ public class RecaptchaClient { Metrics.counter(ASSESSMENT_REASON_COUNTER_NAME, "action", String.valueOf(expectedAction), "score", scoreString(assessment.getRiskAnalysis().getScore()), - "reason", reason.name()); + "reason", reason.name()) + .increment(); } final float score = assessment.getRiskAnalysis().getScore(); return new AssessmentResult( @@ -142,7 +143,8 @@ public class RecaptchaClient { } else { Metrics.counter(INVALID_REASON_COUNTER_NAME, "action", String.valueOf(expectedAction), - "reason", assessment.getTokenProperties().getInvalidReason().name()); + "reason", assessment.getTokenProperties().getInvalidReason().name()) + .increment(); return AssessmentResult.invalid(); } }