diff --git a/redis-dispatch/src/test/java/org/whispersystems/dispatch/DispatchManagerTest.java b/redis-dispatch/src/test/java/org/whispersystems/dispatch/DispatchManagerTest.java index fde46cb98..4410659d6 100644 --- a/redis-dispatch/src/test/java/org/whispersystems/dispatch/DispatchManagerTest.java +++ b/redis-dispatch/src/test/java/org/whispersystems/dispatch/DispatchManagerTest.java @@ -4,28 +4,25 @@ */ package org.whispersystems.dispatch; -import org.junit.Rule; -import org.junit.Test; -import org.junit.rules.ExternalResource; -import org.mockito.ArgumentCaptor; -import org.mockito.invocation.InvocationOnMock; -import org.mockito.stubbing.Answer; -import org.whispersystems.dispatch.io.RedisPubSubConnectionFactory; -import org.whispersystems.dispatch.redis.PubSubConnection; -import org.whispersystems.dispatch.redis.PubSubReply; - -import java.io.IOException; -import java.util.LinkedList; -import java.util.List; -import java.util.Optional; - -import static org.junit.Assert.assertArrayEquals; +import static org.junit.jupiter.api.Assertions.assertArrayEquals; import static org.mockito.Mockito.eq; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.timeout; import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; +import java.util.LinkedList; +import java.util.List; +import java.util.Optional; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; +import org.mockito.ArgumentCaptor; +import org.mockito.stubbing.Answer; +import org.whispersystems.dispatch.io.RedisPubSubConnectionFactory; +import org.whispersystems.dispatch.redis.PubSubConnection; +import org.whispersystems.dispatch.redis.PubSubReply; + public class DispatchManagerTest { private PubSubConnection pubSubConnection; @@ -33,31 +30,23 @@ public class DispatchManagerTest { private DispatchManager dispatchManager; private PubSubReplyInputStream pubSubReplyInputStream; - @Rule - public ExternalResource resource = new ExternalResource() { - @Override - protected void before() throws Throwable { - pubSubConnection = mock(PubSubConnection.class ); - socketFactory = mock(RedisPubSubConnectionFactory.class); - pubSubReplyInputStream = new PubSubReplyInputStream(); + @BeforeEach + void setUp() throws Exception { + pubSubConnection = mock(PubSubConnection.class ); + socketFactory = mock(RedisPubSubConnectionFactory.class); + pubSubReplyInputStream = new PubSubReplyInputStream(); - when(socketFactory.connect()).thenReturn(pubSubConnection); - when(pubSubConnection.read()).thenAnswer(new Answer() { - @Override - public PubSubReply answer(InvocationOnMock invocationOnMock) throws Throwable { - return pubSubReplyInputStream.read(); - } - }); + when(socketFactory.connect()).thenReturn(pubSubConnection); + when(pubSubConnection.read()).thenAnswer((Answer) invocationOnMock -> pubSubReplyInputStream.read()); - dispatchManager = new DispatchManager(socketFactory, Optional.empty()); - dispatchManager.start(); - } + dispatchManager = new DispatchManager(socketFactory, Optional.empty()); + dispatchManager.start(); + } - @Override - protected void after() { - - } - }; + @AfterEach + void tearDown() { + dispatchManager.shutdown(); + } @Test public void testConnect() { @@ -65,7 +54,7 @@ public class DispatchManagerTest { } @Test - public void testSubscribe() throws IOException { + public void testSubscribe() { DispatchChannel dispatchChannel = mock(DispatchChannel.class); dispatchManager.subscribe("foo", dispatchChannel); pubSubReplyInputStream.write(new PubSubReply(PubSubReply.Type.SUBSCRIBE, "foo", Optional.empty())); @@ -74,7 +63,7 @@ public class DispatchManagerTest { } @Test - public void testSubscribeUnsubscribe() throws IOException { + public void testSubscribeUnsubscribe() { DispatchChannel dispatchChannel = mock(DispatchChannel.class); dispatchManager.subscribe("foo", dispatchChannel); dispatchManager.unsubscribe("foo", dispatchChannel); @@ -86,7 +75,7 @@ public class DispatchManagerTest { } @Test - public void testMessages() throws IOException { + public void testMessages() { DispatchChannel fooChannel = mock(DispatchChannel.class); DispatchChannel barChannel = mock(DispatchChannel.class); diff --git a/redis-dispatch/src/test/java/org/whispersystems/dispatch/redis/PubSubConnectionTest.java b/redis-dispatch/src/test/java/org/whispersystems/dispatch/redis/PubSubConnectionTest.java index bac7b0565..4e0459359 100644 --- a/redis-dispatch/src/test/java/org/whispersystems/dispatch/redis/PubSubConnectionTest.java +++ b/redis-dispatch/src/test/java/org/whispersystems/dispatch/redis/PubSubConnectionTest.java @@ -4,9 +4,9 @@ */ package org.whispersystems.dispatch.redis; -import static org.junit.Assert.assertArrayEquals; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; +import static org.junit.jupiter.api.Assertions.assertArrayEquals; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.anyInt; import static org.mockito.Mockito.mock; @@ -18,12 +18,12 @@ import java.io.InputStream; import java.io.OutputStream; import java.net.Socket; import java.security.SecureRandom; -import org.junit.Test; +import org.junit.jupiter.api.Test; import org.mockito.ArgumentCaptor; import org.mockito.invocation.InvocationOnMock; import org.mockito.stubbing.Answer; -public class PubSubConnectionTest { +class PubSubConnectionTest { private static final String REPLY = "*3\r\n" + "$9\r\n" + @@ -60,8 +60,7 @@ public class PubSubConnectionTest { @Test - public void testSubscribe() throws IOException { -// ByteChannel byteChannel = mock(ByteChannel.class); + void testSubscribe() throws IOException { OutputStream outputStream = mock(OutputStream.class); Socket socket = mock(Socket.class ); when(socket.getOutputStream()).thenReturn(outputStream); @@ -76,7 +75,7 @@ public class PubSubConnectionTest { } @Test - public void testUnsubscribe() throws IOException { + void testUnsubscribe() throws IOException { OutputStream outputStream = mock(OutputStream.class); Socket socket = mock(Socket.class ); when(socket.getOutputStream()).thenReturn(outputStream); @@ -91,7 +90,7 @@ public class PubSubConnectionTest { } @Test - public void testTricklyResponse() throws Exception { + void testTricklyResponse() throws Exception { InputStream inputStream = mockInputStreamFor(new TrickleInputStream(REPLY.getBytes())); OutputStream outputStream = mock(OutputStream.class); Socket socket = mock(Socket.class ); @@ -103,7 +102,7 @@ public class PubSubConnectionTest { } @Test - public void testFullResponse() throws Exception { + void testFullResponse() throws Exception { InputStream inputStream = mockInputStreamFor(new FullInputStream(REPLY.getBytes())); OutputStream outputStream = mock(OutputStream.class); Socket socket = mock(Socket.class ); @@ -115,7 +114,7 @@ public class PubSubConnectionTest { } @Test - public void testRandomLengthResponse() throws Exception { + void testRandomLengthResponse() throws Exception { InputStream inputStream = mockInputStreamFor(new RandomInputStream(REPLY.getBytes())); OutputStream outputStream = mock(OutputStream.class); Socket socket = mock(Socket.class ); diff --git a/redis-dispatch/src/test/java/org/whispersystems/dispatch/redis/protocol/ArrayReplyHeaderTest.java b/redis-dispatch/src/test/java/org/whispersystems/dispatch/redis/protocol/ArrayReplyHeaderTest.java index afa6cc722..d7346019d 100644 --- a/redis-dispatch/src/test/java/org/whispersystems/dispatch/redis/protocol/ArrayReplyHeaderTest.java +++ b/redis-dispatch/src/test/java/org/whispersystems/dispatch/redis/protocol/ArrayReplyHeaderTest.java @@ -5,42 +5,41 @@ package org.whispersystems.dispatch.redis.protocol; -import org.junit.Test; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; import java.io.IOException; +import org.junit.jupiter.api.Test; -import static org.junit.Assert.assertEquals; +class ArrayReplyHeaderTest { -public class ArrayReplyHeaderTest { - - - @Test(expected = IOException.class) - public void testNull() throws IOException { - new ArrayReplyHeader(null); - } - - @Test(expected = IOException.class) - public void testBadPrefix() throws IOException { - new ArrayReplyHeader(":3"); - } - - @Test(expected = IOException.class) - public void testEmpty() throws IOException { - new ArrayReplyHeader(""); - } - - @Test(expected = IOException.class) - public void testTruncated() throws IOException { - new ArrayReplyHeader("*"); - } - - @Test(expected = IOException.class) - public void testBadNumber() throws IOException { - new ArrayReplyHeader("*ABC"); + @Test + void testNull() { + assertThrows(IOException.class, () -> new ArrayReplyHeader(null)); } @Test - public void testValid() throws IOException { + void testBadPrefix() { + assertThrows(IOException.class, () -> new ArrayReplyHeader(":3")); + } + + @Test + void testEmpty() { + assertThrows(IOException.class, () -> new ArrayReplyHeader("")); + } + + @Test + void testTruncated() { + assertThrows(IOException.class, () -> new ArrayReplyHeader("*")); + } + + @Test + void testBadNumber() { + assertThrows(IOException.class, () -> new ArrayReplyHeader("*ABC")); + } + + @Test + void testValid() throws IOException { assertEquals(4, new ArrayReplyHeader("*4").getElementCount()); } diff --git a/redis-dispatch/src/test/java/org/whispersystems/dispatch/redis/protocol/IntReplyHeaderTest.java b/redis-dispatch/src/test/java/org/whispersystems/dispatch/redis/protocol/IntReplyHeaderTest.java index 8f95aeaf0..a5efb357d 100644 --- a/redis-dispatch/src/test/java/org/whispersystems/dispatch/redis/protocol/IntReplyHeaderTest.java +++ b/redis-dispatch/src/test/java/org/whispersystems/dispatch/redis/protocol/IntReplyHeaderTest.java @@ -4,36 +4,36 @@ */ package org.whispersystems.dispatch.redis.protocol; -import org.junit.Test; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; import java.io.IOException; +import org.junit.jupiter.api.Test; -import static org.junit.Assert.assertEquals; +class IntReplyHeaderTest { -public class IntReplyHeaderTest { - - @Test(expected = IOException.class) - public void testNull() throws IOException { - new IntReply(null); - } - - @Test(expected = IOException.class) - public void testEmpty() throws IOException { - new IntReply(""); - } - - @Test(expected = IOException.class) - public void testBadNumber() throws IOException { - new IntReply(":A"); - } - - @Test(expected = IOException.class) - public void testBadFormat() throws IOException { - new IntReply("*"); + @Test + void testNull() { + assertThrows(IOException.class, () -> new IntReply(null)); } @Test - public void testValid() throws IOException { + void testEmpty() { + assertThrows(IOException.class, () -> new IntReply("")); + } + + @Test + void testBadNumber() { + assertThrows(IOException.class, () -> new IntReply(":A")); + } + + @Test + void testBadFormat() { + assertThrows(IOException.class, () -> new IntReply("*")); + } + + @Test + void testValid() throws IOException { assertEquals(23, new IntReply(":23").getValue()); } } diff --git a/redis-dispatch/src/test/java/org/whispersystems/dispatch/redis/protocol/StringReplyHeaderTest.java b/redis-dispatch/src/test/java/org/whispersystems/dispatch/redis/protocol/StringReplyHeaderTest.java index 1c10848b8..206041b6f 100644 --- a/redis-dispatch/src/test/java/org/whispersystems/dispatch/redis/protocol/StringReplyHeaderTest.java +++ b/redis-dispatch/src/test/java/org/whispersystems/dispatch/redis/protocol/StringReplyHeaderTest.java @@ -4,48 +4,32 @@ */ package org.whispersystems.dispatch.redis.protocol; -import org.junit.Test; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; import java.io.IOException; +import org.junit.jupiter.api.Test; -import static org.junit.Assert.assertEquals; - -public class StringReplyHeaderTest { +class StringReplyHeaderTest { @Test - public void testNull() { - try { - new StringReplyHeader(null); - throw new AssertionError(); - } catch (IOException e) { - // good - } + void testNull() { + assertThrows(IOException.class, () -> new StringReplyHeader(null)); } @Test - public void testBadNumber() { - try { - new StringReplyHeader("$100A"); - throw new AssertionError(); - } catch (IOException e) { - // good - } + void testBadNumber() { + assertThrows(IOException.class, () -> new StringReplyHeader("$100A")); } @Test - public void testBadPrefix() { - try { - new StringReplyHeader("*"); - throw new AssertionError(); - } catch (IOException e) { - // good - } + void testBadPrefix() { + assertThrows(IOException.class, () -> new StringReplyHeader("*")); } @Test - public void testValid() throws IOException { + void testValid() throws IOException { assertEquals(1000, new StringReplyHeader("$1000").getStringLength()); } - }