diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/auth/TurnTokenGenerator.java b/service/src/main/java/org/whispersystems/textsecuregcm/auth/TurnTokenGenerator.java index df6241256..9e7b5d975 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/auth/TurnTokenGenerator.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/auth/TurnTokenGenerator.java @@ -27,21 +27,23 @@ public class TurnTokenGenerator { private final DynamicConfigurationManager dynamicConfiguration; + private static final String ALGORITHM = "HmacSHA1"; + public TurnTokenGenerator(final DynamicConfigurationManager config) { this.dynamicConfiguration = config; } public TurnToken generate(final String e164) { try { - byte[] key = dynamicConfiguration.getConfiguration().getTurnConfiguration().getSecret().getBytes(); - List urls = urls(e164); - Mac mac = Mac.getInstance("HmacSHA1"); - long validUntilSeconds = (System.currentTimeMillis() + TimeUnit.DAYS.toMillis(1)) / 1000; - long user = Util.ensureNonNegativeInt(new SecureRandom().nextInt()); - String userTime = validUntilSeconds + ":" + user; + final byte[] key = dynamicConfiguration.getConfiguration().getTurnConfiguration().getSecret().getBytes(); + final List urls = urls(e164); + final Mac mac = Mac.getInstance(ALGORITHM); + final long validUntilSeconds = (System.currentTimeMillis() + TimeUnit.DAYS.toMillis(1)) / 1000; + final long user = Util.ensureNonNegativeInt(new SecureRandom().nextInt()); + final String userTime = validUntilSeconds + ":" + user; - mac.init(new SecretKeySpec(key, "HmacSHA1")); - String password = Base64.getEncoder().encodeToString(mac.doFinal(userTime.getBytes())); + mac.init(new SecretKeySpec(key, ALGORITHM)); + final String password = Base64.getEncoder().encodeToString(mac.doFinal(userTime.getBytes())); return new TurnToken(userTime, password, urls); } catch (NoSuchAlgorithmException | InvalidKeyException e) { @@ -64,6 +66,6 @@ public class TurnTokenGenerator { return WeightedRandomSelect.select(turnConfig .getUriConfigs() .stream() - .map(c -> new Pair, Long>(c.getUris(), c.getWeight())).toList()); + .map(c -> new Pair<>(c.getUris(), c.getWeight())).toList()); } }