From 391aa9c5180b1d071be6d6a23bbf6a761218d1ac Mon Sep 17 00:00:00 2001
From: Chris Eager <chris@signal.org>
Date: Tue, 28 Mar 2023 11:21:33 -0500
Subject: [PATCH] Wrap runtime exceptions during WebSocket auth into
 AuthenticationException

---
 .../websocket/WebSocketAccountAuthenticator.java     | 12 ++++++++++--
 .../websocket/WebSocketConnectionTest.java           |  2 +-
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/websocket/WebSocketAccountAuthenticator.java b/service/src/main/java/org/whispersystems/textsecuregcm/websocket/WebSocketAccountAuthenticator.java
index c7dc07497..460c5f498 100644
--- a/service/src/main/java/org/whispersystems/textsecuregcm/websocket/WebSocketAccountAuthenticator.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/websocket/WebSocketAccountAuthenticator.java
@@ -12,6 +12,7 @@ import java.util.Optional;
 import org.eclipse.jetty.websocket.api.UpgradeRequest;
 import org.whispersystems.textsecuregcm.auth.AccountAuthenticator;
 import org.whispersystems.textsecuregcm.auth.AuthenticatedAccount;
+import org.whispersystems.websocket.auth.AuthenticationException;
 import org.whispersystems.websocket.auth.WebSocketAuthenticator;
 
 
@@ -24,7 +25,8 @@ public class WebSocketAccountAuthenticator implements WebSocketAuthenticator<Aut
   }
 
   @Override
-  public AuthenticationResult<AuthenticatedAccount> authenticate(UpgradeRequest request) {
+  public AuthenticationResult<AuthenticatedAccount> authenticate(UpgradeRequest request)
+      throws AuthenticationException {
     Map<String, List<String>> parameters = request.getParameterMap();
     List<String> usernames = parameters.get("login");
     List<String> passwords = parameters.get("password");
@@ -37,7 +39,13 @@ public class WebSocketAccountAuthenticator implements WebSocketAuthenticator<Aut
     BasicCredentials credentials = new BasicCredentials(usernames.get(0).replace(" ", "+"),
         passwords.get(0).replace(" ", "+"));
 
-    return new AuthenticationResult<>(accountAuthenticator.authenticate(credentials), true);
+    try {
+      return new AuthenticationResult<>(accountAuthenticator.authenticate(credentials), true);
+    } catch (final Exception e) {
+      // this will be handled and logged upstream
+      // the most likely exception is a transient error connecting to account storage
+      throw new AuthenticationException(e);
+    }
   }
 
 }
diff --git a/service/src/test/java/org/whispersystems/textsecuregcm/websocket/WebSocketConnectionTest.java b/service/src/test/java/org/whispersystems/textsecuregcm/websocket/WebSocketConnectionTest.java
index dbdc2a279..473a9cfe7 100644
--- a/service/src/test/java/org/whispersystems/textsecuregcm/websocket/WebSocketConnectionTest.java
+++ b/service/src/test/java/org/whispersystems/textsecuregcm/websocket/WebSocketConnectionTest.java
@@ -114,7 +114,7 @@ class WebSocketConnectionTest {
   }
 
   @Test
-  void testCredentials() {
+  void testCredentials() throws Exception {
     WebSocketAccountAuthenticator webSocketAuthenticator = new WebSocketAccountAuthenticator(accountAuthenticator);
     AuthenticatedConnectListener connectListener = new AuthenticatedConnectListener(receiptSender, messagesManager,
         mock(PushNotificationManager.class), mock(ClientPresenceManager.class),