MirrorMirror
/
Signal-Server
mirror of https://github.com/signalapp/Signal-Server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Disable flaky VirtualThreadPinEventMonitorTest

This commit is contained in:
Ravi Khadiwala 2024-01-30 13:26:28 -06:00 committed by ravi-signal
parent 4dfd74906c
commit 2c1e7e5ed6
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
service/src/test/java/org/whispersystems/textsecuregcm/util/VirtualThreadPinEventMonitorTest.java
View File

@ -16,6 +16,7 @@ import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeUnit;
import jdk.jfr.consumer.RecordedEvent; import jdk.jfr.consumer.RecordedEvent;
import org.apache.commons.lang3.tuple.Pair; import org.apache.commons.lang3.tuple.Pair;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource; import org.junit.jupiter.params.provider.ValueSource;
@ -43,6 +44,7 @@ public class VirtualThreadPinEventMonitorTest {
} }
@Test @Test
@Disabled("flaky: no way to ensure the sequencing between the start of the recording stream and emitting the event")
public void testPinEventProduced() throws InterruptedException, ExecutionException { public void testPinEventProduced() throws InterruptedException, ExecutionException {
final BlockingQueue<Pair<RecordedEvent, Boolean>> bq = new LinkedBlockingQueue<>(); final BlockingQueue<Pair<RecordedEvent, Boolean>> bq = new LinkedBlockingQueue<>();
final ExecutorService exec = Executors.newVirtualThreadPerTaskExecutor(); final ExecutorService exec = Executors.newVirtualThreadPerTaskExecutor();
@ -63,6 +65,7 @@ public class VirtualThreadPinEventMonitorTest {
@ParameterizedTest @ParameterizedTest
@ValueSource(strings = {"VirtualThreadPinEventMonitorTest.synchronizedSleep1", "synchronizedSleep1"}) @ValueSource(strings = {"VirtualThreadPinEventMonitorTest.synchronizedSleep1", "synchronizedSleep1"})
@Disabled("flaky: no way to ensure the sequencing between the start of the recording stream and emitting the event")
public void testPinEventFiltered(final String allowString) throws InterruptedException, ExecutionException { public void testPinEventFiltered(final String allowString) throws InterruptedException, ExecutionException {
final BlockingQueue<Pair<RecordedEvent, Boolean>> bq = new LinkedBlockingQueue<>(); final BlockingQueue<Pair<RecordedEvent, Boolean>> bq = new LinkedBlockingQueue<>();
final ExecutorService exec = Executors.newVirtualThreadPerTaskExecutor(); final ExecutorService exec = Executors.newVirtualThreadPerTaskExecutor();