MirrorMirror
/
Signal-Server
mirror of https://github.com/signalapp/Signal-Server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Usernames can't start with numbers

This commit is contained in:
Moxie Marlinspike 2019-10-28 12:51:19 -07:00
parent 523134f24b
commit 2b987e6e93
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
service/src/main/java/org/whispersystems/textsecuregcm/controllers/AccountController.java
View File

@ -540,7 +540,7 @@ public class AccountController {
username = username.toLowerCase();
if (!username.matches("^[a-z0-9_]+$")) {
if (!username.matches("^[a-z_][a-z0-9_]+$")) {
return Response.status(Response.Status.BAD_REQUEST).build();
}

12
service/src/test/java/org/whispersystems/textsecuregcm/tests/controllers/AccountControllerTest.java
View File

@ -864,6 +864,18 @@ public class AccountControllerTest {
assertThat(response.getStatus()).isEqualTo(400);
}
@Test
public void testSetInvalidPrefixUsername() {
Response response =
resources.getJerseyTest()
.target("/v1/accounts/username/0n00bkiller")
.request()
.header("Authorization", AuthHelper.getAuthHeader(AuthHelper.VALID_NUMBER, AuthHelper.VALID_PASSWORD))
.put(Entity.text(""));
assertThat(response.getStatus()).isEqualTo(400);
}
@Test
public void testSetUsernameBadAuth() {
Response response =