diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/auth/AuthEnablementRefreshRequirementProvider.java b/service/src/main/java/org/whispersystems/textsecuregcm/auth/LinkedDeviceRefreshRequirementProvider.java similarity index 87% rename from service/src/main/java/org/whispersystems/textsecuregcm/auth/AuthEnablementRefreshRequirementProvider.java rename to service/src/main/java/org/whispersystems/textsecuregcm/auth/LinkedDeviceRefreshRequirementProvider.java index cb7746a02..12060f2ea 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/auth/AuthEnablementRefreshRequirementProvider.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/auth/LinkedDeviceRefreshRequirementProvider.java @@ -27,16 +27,16 @@ import org.whispersystems.textsecuregcm.util.Pair; * * @see AuthenticatedAccount */ -public class AuthEnablementRefreshRequirementProvider implements WebsocketRefreshRequirementProvider { +public class LinkedDeviceRefreshRequirementProvider implements WebsocketRefreshRequirementProvider { private final AccountsManager accountsManager; - private static final Logger logger = LoggerFactory.getLogger(AuthEnablementRefreshRequirementProvider.class); + private static final Logger logger = LoggerFactory.getLogger(LinkedDeviceRefreshRequirementProvider.class); - private static final String ACCOUNT_UUID = AuthEnablementRefreshRequirementProvider.class.getName() + ".accountUuid"; - private static final String LINKED_DEVICE_IDS = AuthEnablementRefreshRequirementProvider.class.getName() + ".deviceIds"; + private static final String ACCOUNT_UUID = LinkedDeviceRefreshRequirementProvider.class.getName() + ".accountUuid"; + private static final String LINKED_DEVICE_IDS = LinkedDeviceRefreshRequirementProvider.class.getName() + ".deviceIds"; - public AuthEnablementRefreshRequirementProvider(final AccountsManager accountsManager) { + public LinkedDeviceRefreshRequirementProvider(final AccountsManager accountsManager) { this.accountsManager = accountsManager; } diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/auth/WebsocketRefreshApplicationEventListener.java b/service/src/main/java/org/whispersystems/textsecuregcm/auth/WebsocketRefreshApplicationEventListener.java index 4ad8c67ca..2f54d78ba 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/auth/WebsocketRefreshApplicationEventListener.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/auth/WebsocketRefreshApplicationEventListener.java @@ -23,7 +23,7 @@ public class WebsocketRefreshApplicationEventListener implements ApplicationEven final ClientPresenceManager clientPresenceManager) { this.websocketRefreshRequestEventListener = new WebsocketRefreshRequestEventListener(clientPresenceManager, - new AuthEnablementRefreshRequirementProvider(accountsManager), + new LinkedDeviceRefreshRequirementProvider(accountsManager), new PhoneNumberChangeRefreshRequirementProvider(accountsManager)); } diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/controllers/DeviceController.java b/service/src/main/java/org/whispersystems/textsecuregcm/controllers/DeviceController.java index 8e7413244..c948fb829 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/controllers/DeviceController.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/controllers/DeviceController.java @@ -46,7 +46,7 @@ import javax.ws.rs.core.Context; import javax.ws.rs.core.MediaType; import javax.ws.rs.core.Response; import org.glassfish.jersey.server.ContainerRequest; -import org.whispersystems.textsecuregcm.auth.AuthEnablementRefreshRequirementProvider; +import org.whispersystems.textsecuregcm.auth.LinkedDeviceRefreshRequirementProvider; import org.whispersystems.textsecuregcm.auth.AuthenticatedAccount; import org.whispersystems.textsecuregcm.auth.BasicAuthorizationHeader; import org.whispersystems.textsecuregcm.auth.ChangesLinkedDevices; @@ -221,7 +221,7 @@ public class DeviceController { // Normally, the "do we need to refresh somebody's websockets" listener can do this on its own. In this case, // we're not using the conventional authentication system, and so we need to give it a hint so it knows who the // active user is and what their device states look like. - AuthEnablementRefreshRequirementProvider.setAccount(containerRequest, account); + LinkedDeviceRefreshRequirementProvider.setAccount(containerRequest, account); final int maxDeviceLimit = maxDeviceConfiguration.getOrDefault(account.getNumber(), MAX_DEVICES); diff --git a/service/src/test/java/org/whispersystems/textsecuregcm/auth/AuthEnablementRefreshRequirementProviderTest.java b/service/src/test/java/org/whispersystems/textsecuregcm/auth/LinkedDeviceRefreshRequirementProviderTest.java similarity index 96% rename from service/src/test/java/org/whispersystems/textsecuregcm/auth/AuthEnablementRefreshRequirementProviderTest.java rename to service/src/test/java/org/whispersystems/textsecuregcm/auth/LinkedDeviceRefreshRequirementProviderTest.java index 83180ca32..166e86438 100644 --- a/service/src/test/java/org/whispersystems/textsecuregcm/auth/AuthEnablementRefreshRequirementProviderTest.java +++ b/service/src/test/java/org/whispersystems/textsecuregcm/auth/LinkedDeviceRefreshRequirementProviderTest.java @@ -10,7 +10,6 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import static org.mockito.ArgumentMatchers.any; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.never; -import static org.mockito.Mockito.times; import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.when; @@ -32,17 +31,13 @@ import java.util.Arrays; import java.util.Base64; import java.util.LinkedList; import java.util.List; -import java.util.Map; -import java.util.Map.Entry; import java.util.Optional; import java.util.UUID; import java.util.function.Supplier; import java.util.stream.Collectors; import java.util.stream.IntStream; -import java.util.stream.Stream; import javax.ws.rs.DELETE; import javax.ws.rs.GET; -import javax.ws.rs.POST; import javax.ws.rs.PUT; import javax.ws.rs.Path; import javax.ws.rs.PathParam; @@ -62,8 +57,6 @@ import org.junit.jupiter.api.Nested; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; import org.junit.jupiter.params.ParameterizedTest; -import org.junit.jupiter.params.provider.Arguments; -import org.junit.jupiter.params.provider.MethodSource; import org.junit.jupiter.params.provider.ValueSource; import org.mockito.ArgumentCaptor; import org.whispersystems.textsecuregcm.filters.RemoteAddressFilter; @@ -83,7 +76,7 @@ import org.whispersystems.websocket.messages.protobuf.SubProtocol; import org.whispersystems.websocket.session.WebSocketSessionContextValueFactoryProvider; @ExtendWith(DropwizardExtensionsSupport.class) -class AuthEnablementRefreshRequirementProviderTest { +class LinkedDeviceRefreshRequirementProviderTest { private final ApplicationEventListener applicationEventListener = mock(ApplicationEventListener.class); @@ -105,14 +98,14 @@ class AuthEnablementRefreshRequirementProviderTest { private AccountsManager accountsManager; private ClientPresenceManager clientPresenceManager; - private AuthEnablementRefreshRequirementProvider provider; + private LinkedDeviceRefreshRequirementProvider provider; @BeforeEach void setup() { accountsManager = mock(AccountsManager.class); clientPresenceManager = mock(ClientPresenceManager.class); - provider = new AuthEnablementRefreshRequirementProvider(accountsManager); + provider = new LinkedDeviceRefreshRequirementProvider(accountsManager); final WebsocketRefreshRequestEventListener listener = new WebsocketRefreshRequestEventListener(clientPresenceManager, provider);