From 17cfd4924c55f9a5860b0778d924052da7faa08d Mon Sep 17 00:00:00 2001
From: Jon Chambers <jon@signal.org>
Date: Thu, 11 Jun 2020 16:43:34 -0400
Subject: [PATCH] Fixed a poorly-mirrored write operation to the new cluster.

---
 .../textsecuregcm/storage/UsernamesManager.java  | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/storage/UsernamesManager.java b/service/src/main/java/org/whispersystems/textsecuregcm/storage/UsernamesManager.java
index 4bd329e35..bd3d697da 100644
--- a/service/src/main/java/org/whispersystems/textsecuregcm/storage/UsernamesManager.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/storage/UsernamesManager.java
@@ -181,18 +181,16 @@ public class UsernamesManager {
       final String uuidMapKey = getUuidMapKey(uuid);
 
       redisGet(uuid).ifPresent(username -> {
-        jedis.del(getUsernameMapKey(username));
+        final String usernameMapKey = getUsernameMapKey(username);
+
+        jedis.del(usernameMapKey);
         jedis.del(uuidMapKey);
-      });
 
-      cacheCluster.useWriteCluster(connection -> {
-        final RedisAdvancedClusterAsyncCommands<String, String> asyncCommands = connection.async();
+        cacheCluster.useWriteCluster(connection -> {
+          final RedisAdvancedClusterAsyncCommands<String, String> asyncCommands = connection.async();
 
-        asyncCommands.get(uuidMapKey).thenAccept(username -> {
-          if (username != null) {
-            asyncCommands.del(getUsernameMapKey(username));
-            asyncCommands.del(uuidMapKey);
-          }
+          asyncCommands.del(usernameMapKey);
+          asyncCommands.del(uuidMapKey);
         });
       });
     }