Count non-normalized or impossible numbers

This commit is contained in:
Jon Chambers 2021-10-20 16:15:56 -04:00 committed by Jon Chambers
parent 534c577f59
commit 11598e855f
2 changed files with 18 additions and 0 deletions

View File

@ -5,14 +5,23 @@
package org.whispersystems.textsecuregcm.mappers; package org.whispersystems.textsecuregcm.mappers;
import io.micrometer.core.instrument.Counter;
import io.micrometer.core.instrument.Metrics;
import org.whispersystems.textsecuregcm.util.ImpossiblePhoneNumberException; import org.whispersystems.textsecuregcm.util.ImpossiblePhoneNumberException;
import javax.ws.rs.core.Response; import javax.ws.rs.core.Response;
import javax.ws.rs.ext.ExceptionMapper; import javax.ws.rs.ext.ExceptionMapper;
import static org.whispersystems.textsecuregcm.metrics.MetricsUtil.name;
public class ImpossiblePhoneNumberExceptionMapper implements ExceptionMapper<ImpossiblePhoneNumberException> { public class ImpossiblePhoneNumberExceptionMapper implements ExceptionMapper<ImpossiblePhoneNumberException> {
private static final Counter IMPOSSIBLE_NUMBER_COUNTER =
Metrics.counter(name(ImpossiblePhoneNumberExceptionMapper.class, "impossibleNumbers"));
@Override @Override
public Response toResponse(final ImpossiblePhoneNumberException exception) { public Response toResponse(final ImpossiblePhoneNumberException exception) {
IMPOSSIBLE_NUMBER_COUNTER.increment();
return Response.status(Response.Status.BAD_REQUEST).build(); return Response.status(Response.Status.BAD_REQUEST).build();
} }
} }

View File

@ -5,15 +5,24 @@
package org.whispersystems.textsecuregcm.mappers; package org.whispersystems.textsecuregcm.mappers;
import io.micrometer.core.instrument.Counter;
import io.micrometer.core.instrument.Metrics;
import org.whispersystems.textsecuregcm.util.NonNormalizedPhoneNumberException; import org.whispersystems.textsecuregcm.util.NonNormalizedPhoneNumberException;
import javax.ws.rs.core.Response; import javax.ws.rs.core.Response;
import javax.ws.rs.core.Response.Status; import javax.ws.rs.core.Response.Status;
import javax.ws.rs.ext.ExceptionMapper; import javax.ws.rs.ext.ExceptionMapper;
import static org.whispersystems.textsecuregcm.metrics.MetricsUtil.name;
public class NonNormalizedPhoneNumberExceptionMapper implements ExceptionMapper<NonNormalizedPhoneNumberException> { public class NonNormalizedPhoneNumberExceptionMapper implements ExceptionMapper<NonNormalizedPhoneNumberException> {
private static final Counter NON_NORMALIZED_NUMBER_COUNTER =
Metrics.counter(name(NonNormalizedPhoneNumberExceptionMapper.class, "nonNormalizedNumbers"));
@Override @Override
public Response toResponse(final NonNormalizedPhoneNumberException exception) { public Response toResponse(final NonNormalizedPhoneNumberException exception) {
NON_NORMALIZED_NUMBER_COUNTER.increment();
return Response.status(Status.BAD_REQUEST) return Response.status(Status.BAD_REQUEST)
.entity(new NonNormalizedPhoneNumberResponse(exception.getOriginalNumber(), exception.getNormalizedNumber())) .entity(new NonNormalizedPhoneNumberResponse(exception.getOriginalNumber(), exception.getNormalizedNumber()))
.build(); .build();