From 103b49ec459301b81799ec8e4a3272a3cc7244b9 Mon Sep 17 00:00:00 2001 From: Jon Chambers Date: Thu, 29 Oct 2020 10:34:30 -0400 Subject: [PATCH] Record the number of non-success responses from clients when sending messages via websockets. --- .../textsecuregcm/websocket/WebSocketConnection.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/websocket/WebSocketConnection.java b/service/src/main/java/org/whispersystems/textsecuregcm/websocket/WebSocketConnection.java index 5242881d7..9bd38aaf8 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/websocket/WebSocketConnection.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/websocket/WebSocketConnection.java @@ -57,6 +57,7 @@ public class WebSocketConnection implements MessageAvailabilityListener, Displac private static final Meter messagesPersistedMeter = metricRegistry.meter(name(WebSocketConnection.class, "messagesPersisted")); private static final Meter bytesSentMeter = metricRegistry.meter(name(WebSocketConnection.class, "bytes_sent")); private static final Meter sendFailuresMeter = metricRegistry.meter(name(WebSocketConnection.class, "send_failures")); + private static final Meter clientNonSuccessResponseMeter = metricRegistry.meter(name(WebSocketConnection.class, "clientNonSuccessResponse")); private static final String DISPLACEMENT_COUNTER_NAME = name(WebSocketConnection.class, "displacement"); private static final String DISPLACEMENT_PLATFORM_TAG_NAME = "platform"; @@ -128,6 +129,8 @@ public class WebSocketConnection implements MessageAvailabilityListener, Displac messageTime.update(System.currentTimeMillis() - message.getTimestamp()); sendDeliveryReceiptFor(message); } + } else { + clientNonSuccessResponseMeter.mark(); } } else { sendFailuresMeter.mark();