MirrorMirror
/
Signal-Server
mirror of https://github.com/signalapp/Signal-Server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid blocking calls in async account updates

This commit is contained in:
Jon Chambers 2023-11-13 12:14:37 -05:00 committed by Jon Chambers
parent 521900c048
commit 07c04006df
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
service/src/main/java/org/whispersystems/textsecuregcm/storage/Accounts.java
View File

@ -807,14 +807,17 @@ public class Accounts extends AbstractDynamoDbStore {
account.setVersion(AttributeValues.getInt(response.attributes(), "V", account.getVersion() + 1)); account.setVersion(AttributeValues.getInt(response.attributes(), "V", account.getVersion() + 1));
return (Void) null; return (Void) null;
}) })
.exceptionally(throwable -> { .exceptionallyCompose(throwable -> {
final Throwable unwrapped = ExceptionUtils.unwrap(throwable); final Throwable unwrapped = ExceptionUtils.unwrap(throwable);
if (unwrapped instanceof TransactionConflictException) { if (unwrapped instanceof TransactionConflictException) {
throw new ContestedOptimisticLockException(); throw new ContestedOptimisticLockException();
} else if (unwrapped instanceof ConditionalCheckFailedException e) { } else if (unwrapped instanceof ConditionalCheckFailedException e) {
// the exception doesn't give details about which condition failed, // the exception doesn't give details about which condition failed,
// but we can infer it was an optimistic locking failure if the UUID is known // but we can infer it was an optimistic locking failure if the UUID is known
throw getByAccountIdentifier(account.getUuid()).isPresent() ? new ContestedOptimisticLockException() : e; return getByAccountIdentifierAsync(account.getUuid())
.thenAccept(refreshedAccount -> {
throw refreshedAccount.isPresent() ? new ContestedOptimisticLockException() : e;
});
} else { } else {
// rethrow // rethrow
throw CompletableFutureUtils.errorAsCompletionException(throwable); throw CompletableFutureUtils.errorAsCompletionException(throwable);