From 06c391cbf60a265ecc59b0471b1dc8acfb4846c2 Mon Sep 17 00:00:00 2001
From: Chris Eager <chris@signal.org>
Date: Wed, 20 Dec 2023 12:23:33 -0600
Subject: [PATCH] Add counter for failed account updates to
 RemoveExpiredLinkedDevicesCommand

---
 .../workers/RemoveExpiredLinkedDevicesCommand.java         | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/workers/RemoveExpiredLinkedDevicesCommand.java b/service/src/main/java/org/whispersystems/textsecuregcm/workers/RemoveExpiredLinkedDevicesCommand.java
index 6360fcd38..38b0e6a90 100644
--- a/service/src/main/java/org/whispersystems/textsecuregcm/workers/RemoveExpiredLinkedDevicesCommand.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/workers/RemoveExpiredLinkedDevicesCommand.java
@@ -30,6 +30,9 @@ public class RemoveExpiredLinkedDevicesCommand extends AbstractSinglePassCrawlAc
       "removedDevices");
   private static final String UPDATED_ACCOUNTS_COUNTER_NAME = name(RemoveExpiredLinkedDevicesCommand.class,
       "updatedAccounts");
+
+  private static final String FAILED_ACCOUNT_UPDATES_COUNTER_NAME = name(RemoveExpiredLinkedDevicesCommand.class,
+      "failedAccountUpdates");
   private static final Logger logger = LoggerFactory.getLogger(RemoveExpiredLinkedDevicesCommand.class);
 
   public RemoveExpiredLinkedDevicesCommand() {
@@ -65,8 +68,8 @@ public class RemoveExpiredLinkedDevicesCommand extends AbstractSinglePassCrawlAc
 
           return accountUpdate.thenReturn(expiredDevices.size())
               .onErrorResume(t -> {
-                logger.warn("Failed to remove expired linked devices {}", account.getUuid(),
-                    t);
+                logger.warn("Failed to remove expired linked devices {}", account.getUuid(), t);
+                Metrics.counter(FAILED_ACCOUNT_UPDATES_COUNTER_NAME).increment();
                 return Mono.empty();
               });